Please ignore, I'll send a new version. On 8/21/19 7:17 PM, Chaitanya Kulkarni wrote: > On 8/21/19 5:59 PM, Christoph Hellwig wrote: >> On Tue, Aug 20, 2019 at 11:13:14PM -0700, Chaitanya Kulkarni wrote: >>> This patch creates a helper function for handling the request >>> completion in the null_handle_cmd(). >>> >>> Reviewed-by: Christoph Hellwig <hch@xxxxxx> >>> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@xxxxxxx> >>> --- >>> drivers/block/null_blk_main.c | 49 +++++++++++++++++++---------------- >>> 1 file changed, 27 insertions(+), 22 deletions(-) >>> >>> diff --git a/drivers/block/null_blk_main.c b/drivers/block/null_blk_main.c >>> index 501af79bffb2..fe12ec59b3a6 100644 >>> --- a/drivers/block/null_blk_main.c >>> +++ b/drivers/block/null_blk_main.c >>> @@ -1202,6 +1202,32 @@ static inline blk_status_t null_handle_zoned(struct nullb_cmd *cmd, >>> return sts; >>> } >>> >>> +static inline void nullb_handle_cmd_completion(struct nullb_cmd *cmd) >> Maybe cal this nullb_complete_cmd instead? > Okay. > > Jens do you want me to send new series with above fix or it can be done > > at the time of applying the patch to minimize the emails ? either way > I'm fine. > >> Otherwise looks fine: >> >> Reviewed-by: Christoph Hellwig <hch@xxxxxx> >
