The re-definition error is thrown only when 2 different values are assigned to the same #define variable. But in this case, the same value is defined twice... hence the compiler doesn't throw error. Thank you :) Revanth Rajashekar -----Original Message----- From: Scott Bauer [mailto:sbauer@xxxxxxxxxxxxxx] Sent: Wednesday, August 14, 2019 10:08 PM To: Rajashekar, Revanth <revanth.rajashekar@xxxxxxxxx> Cc: linux-block@xxxxxxxxxxxxxxx; Derrick, Jonathan <jonathan.derrick@xxxxxxxxx> Subject: Re: [PATCH 3/3] block: sed-opal: OPAL_METHOD_LENGTH defined twice On Tue, Aug 13, 2019 at 03:43:40PM -0600, Revanth Rajashekar wrote: > Signed-off-by: Revanth Rajashekar <revanth.rajashekar@xxxxxxxxx> Reviewed-by: Scott Bauer <sbauer@xxxxxxxxxxxxxx> Two things, Can we also change the title of this commit to: "Removed duplicate OPAL_METHOD_LENGTH definition" 2nd, I'm dumb as hell now adays, why doesn't this throw a compiler error for multiple declarations?
