lgtm
Reviewed-by: Jon Derrick <jonathan.derrick@xxxxxxxxx>
On Tue, 2019-08-13 at 15:43 -0600, Rajashekar, Revanth wrote:
> In the function 'response_parse', num_entries will never be 0 as
> slen is checked for 0. Hence, the condition 'if (num_entries == 0)'
> can never be true.
>
> Signed-off-by: Revanth Rajashekar <revanth.rajashekar@xxxxxxxxx>
> ---
> block/sed-opal.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/block/sed-opal.c b/block/sed-opal.c
> index d442f29e84f1..4e95a9792162 100644
> --- a/block/sed-opal.c
> +++ b/block/sed-opal.c
> @@ -905,10 +905,6 @@ static int response_parse(const u8 *buf, size_t length,
> num_entries++;
> }
>
> - if (num_entries == 0) {
> - pr_debug("Couldn't parse response.\n");
> - return -EINVAL;
> - }
> resp->num = num_entries;
>
> return 0;
> --
> 2.17.1
>
Attachment:
smime.p7s
Description: S/MIME cryptographic signature
