On 2019-08-14 8:26 a.m., Max Gurtovoy wrote: > > On 8/2/2019 2:45 AM, Logan Gunthorpe wrote: >> From: Chaitanya Kulkarni <chaitanya.kulkarni@xxxxxxx> >> >> Change the return value for nvmet_add_async_event(). >> >> This change is needed for the target passthru code to generate async >> events. > > As a stand alone commit it's not clear what is the purpose of it. > > Please add some extra explanation in the commit message. > > Also better to use integer as return value if the return value should > reflect return code. Thanks for the Review, Max. I'll queue up these changes for v8. Logan
