On 8/9/19 3:54 AM, Marcos Paulo de Souza wrote: > After checking the request_queue argument of funtion blk_execute_rq_nowait, I > now added three more patches, one to remove the same argument from > blk_execute_rq and other two to change the at_head argument from > blk_exeute_rq_{nowait} from int to bool. > > Original patch can be checked here[1]. > > After this patch gets merged, my plan is to analyse the usage the gendisk > argument, is being set as NULL but the majority of callers. > > [1]: https://lkml.org/lkml/2019/8/6/31 Don't ever send something out that hasn't even been compiled. I already detest doing kernel-wide cleanup changes like this, but when I do, I need absolute confidence in it actually being tested. The fact that it hasn't even been compiled is a big black mark on the submitter. -- Jens Axboe