Re: [PATCH -next] lightnvm: Fix unused variable warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 09, 2019 at 05:18:16PM +0800, Shaokun Zhang wrote:
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> drivers/lightnvm/pblk-read.c: In function ‘pblk_submit_read_gc’:
> drivers/lightnvm/pblk-read.c:421:18: warning: unused variable ‘geo’ [-Wunused-variable]
>   struct nvm_geo *geo = &dev->geo;
>                   ^
> Fixes: ba6f7da99aaf ("lightnvm: remove set but not used variables 'data_len' and 'rq_len'")
> Cc: Matias Bjorling <mb@xxxxxxxxxxx>
> Cc: Jens Axboe <axboe@xxxxxxxxx>
> Signed-off-by: Shaokun Zhang <zhangshaokun@xxxxxxxxxxxxx>
> ---
>  drivers/lightnvm/pblk-read.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/lightnvm/pblk-read.c b/drivers/lightnvm/pblk-read.c
> index 0cdc48f9cfbf..8efd14e683dc 100644
> --- a/drivers/lightnvm/pblk-read.c
> +++ b/drivers/lightnvm/pblk-read.c
> @@ -417,8 +417,6 @@ static int read_rq_gc(struct pblk *pblk, struct nvm_rq *rqd,
>  
>  int pblk_submit_read_gc(struct pblk *pblk, struct pblk_gc_rq *gc_rq)
>  {
> -	struct nvm_tgt_dev *dev = pblk->dev;
> -	struct nvm_geo *geo = &dev->geo;
>  	struct nvm_rq rqd;
>  	int ret = NVM_IO_OK;
>  

Jens went ahead and already fixed this one in for-next:
https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?h=for-next&id=f0e6f41669d9e07f45b472e4de33d7c233a847bd

> -- 
> 2.7.4
> 



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux