Re: [PATCH] block: only set DYING flag once in blk_cleanup_queue()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/7/19 7:06 PM, Dmitry Fomichev wrote:
> This commit removes the statement in blk_cleanup_queue() function that
> marks the queue as dying. QUEUE_FLAG_DYING is already set inside
> blk_set_queue_dying() a few lines above, no need to do it again.
> 
> No functional change.
> 
> Signed-off-by: Dmitry Fomichev <dmitry.fomichev@xxxxxxx>
> Reviewed-by: Damien Le Moal <damien.lemoal@xxxxxxx>
> ---
>  block/blk-core.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/block/blk-core.c b/block/blk-core.c
> index d0cc6e14d2f0..0822acc423a3 100644
> --- a/block/blk-core.c
> +++ b/block/blk-core.c
> @@ -339,7 +339,6 @@ void blk_cleanup_queue(struct request_queue *q)
>  
>  	blk_queue_flag_set(QUEUE_FLAG_NOMERGES, q);
>  	blk_queue_flag_set(QUEUE_FLAG_NOXMERGES, q);
> -	blk_queue_flag_set(QUEUE_FLAG_DYING, q);
>  	mutex_unlock(&q->sysfs_lock);

Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux