On Thu, Aug 08, 2019 at 09:11:00PM +0800, Chuhong Yuan wrote: > Reference counters are preferred to use refcount_t instead of > atomic_t. > This is because the implementation of refcount_t can prevent > overflows and detect possible use-after-free. > So convert atomic_t ref counters to refcount_t. Thanks! I think there are more reference counters in blkback than the one you fixed. There's also an inflight field in xen_blkif_ring, and a pendcnt in pending_req which look like possible candidates to switch to use refcount_t, have you looked into switching those two also? Roger.