On 06/08/2019 01:25, Bart Van Assche wrote:
[...]
> + for ((i=0;i<10;i++)); do
> + [ -e /sys/block/$dev/uuid ] &&
> + [ -e /sys/block/$dev/wwid ] &&
> + return 0
> + sleep .1
> + done
> + return 1
> fi
> done
> + return 1
Hmmm, I don't really understand why you're adding the return {0,1} here.
None of the callers of _find_nvme_loop_dev() does anything with the
return value of the function.
They expect either a nvme-device or an empty string and fail if the
string is empty due to a non-empty diff in the golden output.
Thanks,
Johannes
--
Johannes Thumshirn SUSE Labs Filesystems
jthumshirn@xxxxxxx +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
