On 7/3/19 6:39 AM, Jens Axboe wrote: > We should let normal branch prediction handle this. What if you > are running a pure discard workload? Hmm, I'm wasn't aware of such workload especially for null_blk where disacard is being used with memory back-end, I'll keep in mind from next time. > In general I'm not a huge fan of likely/unlikely annotations, > they only tend to make sense when it's an unlikely() for an > error case, not for something that could potentially be quite > the opposite of an unlikely case. Make sense to drop this patch and future such usage of likely()/unlikely() usage. Thanks for the clarification. > > -- Jens Axboe
