On 6/6/19 6:52 AM, Omar Sandoval wrote: > On Fri, May 31, 2019 at 10:59:12AM +0900, Shin'ichiro Kawasaki wrote: >> As a preparation for the zone mapping test case, add several helper >> functions. _find_last_sequential_zone() and >> _find_sequential_zone_in_middle() help to select test target zones. >> _test_dev_is_logical() checks TEST_DEV is the valid test target. >> _test_dev_has_dm_map() helps to check that the dm target is linear or >> flakey. _get_dev_container_and_sector() helps to get the container device >> and sector mappings. > > This has a few shellcheck warnings: > > tests/zbd/rc:221:4: error: Remove '$' or use '_=$((expr))' to avoid executing output. [SC2084] > tests/zbd/rc:223:4: error: Remove '$' or use '_=$((expr))' to avoid executing output. [SC2084] > tests/zbd/rc:225:3: error: Remove '$' or use '_=$((expr))' to avoid executing output. [SC2084] > > And it's missing your Signed-off-by. > > Thanks! Thank you for the review and sorry about the mistakes. Will fix with v3 patch. -- Best Regards, Shin'ichiro Kawasaki
