Looks good. Reviewed-by: Chaitanya Kulkarni <chiatanya.kulkarni@xxxxxxx> On 5/30/19 5:01 PM, Bart Van Assche wrote: > Document all bsg_setup_queue() arguments as required. > > Fixes: aae3b069d5ce ("bsg: pass in desired timeout handler") # v5.0. > Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx> > --- > block/bsg-lib.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/block/bsg-lib.c b/block/bsg-lib.c > index b898a1cdf872..785dd58947f1 100644 > --- a/block/bsg-lib.c > +++ b/block/bsg-lib.c > @@ -354,6 +354,7 @@ static const struct blk_mq_ops bsg_mq_ops = { > * @dev: device to attach bsg device to > * @name: device to give bsg device > * @job_fn: bsg job handler > + * @timeout: timeout handler function pointer > * @dd_job_size: size of LLD data needed for each job > */ > struct request_queue *bsg_setup_queue(struct device *dev, const char *name, >