On Mon, Mar 25, 2019 at 05:19:34AM +0000, Chaitanya Kulkarni wrote: > > @@ -913,9 +902,14 @@ static blk_status_t nvme_queue_rq(struct blk_mq_hw_ctx *hctx, > > struct nvme_queue *nvmeq = hctx->driver_data; > > struct nvme_dev *dev = nvmeq->dev; > > struct request *req = bd->rq; > > + struct nvme_iod *iod = blk_mq_rq_to_pdu(req); > > struct nvme_command cmnd; > > blk_status_t ret; > > > > + iod->aborted = 0; > > + iod->npages = -1; > > + iod->nents = 0; > > + > Maybe add an inline helper for above default IOD initialization ? Why? It is a few lines of code and we only ever do it here.