On Fri, Mar 22, 2019 at 02:06:43PM +0100, Johannes Thumshirn wrote: > On 22/03/2019 00:10, Christoph Hellwig wrote: > > In a lot of places we want to know the DMA direction for a given > > struct request. Add a little helper to make it a littler easier. > > You introuduce the helper here but you're using it in 8/15 for the 1st time. > > Could you convert the possible users to use the new helper in this patch > as well? I'd rather not throw that into a nvme series. Those are easily cleanups for later. Maybe we can even encourage people that would otherwise do whitespace cleanups or incorrect refcount_t conversions to take care of it :)