On 22/03/2019 15:01, Christoph Hellwig wrote: >> + if (bio->bi_phys_segments == -1) >> + bio->bi_phys_segments = 1; >> + else >> + bio->bi_phys_segments++; > > Minor nitpickm but I'd kust write this as: > > if (bio->bi_phys_segments == -1) > bio->bi_phys_segments = 0; > bio->bi_phys_segments++; Yeah, that looks more obvious -- Johannes Thumshirn SUSE Labs Filesystems jthumshirn@xxxxxxx +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
