On Fri, Mar 08, 2019 at 01:25:16PM -0800, Bart Van Assche wrote: > On Fri, 2019-03-08 at 14:14 -0700, Keith Busch wrote: > > On Fri, Mar 08, 2019 at 12:47:10PM -0800, Bart Van Assche wrote: > > > If no such mechanism has been defined in the NVMe spec: have you considered > > > to cancel all outstanding requests instead of calling blk_mq_end_request() for > > > all outstanding requests? > > > > Isn't this cancelling requests? Is there an existing block interface > > that accomplishes this? > > Hi Keith, > > Sorry if I was unclear. With "canceling outstanding requests" I was referring to > the NVMe abort command. I think aborting outstanding requests has the advantage > that no new explicit call to blk_mq_end_request() call has to be added. Ah, gotchya. NVMe abort usage is different than what this series wants to do: we've determined the device is no longer usable, we need to terminate all requests that are queued in software, but haven't been dispatched to hardware.
