On Wed, Feb 20, 2019 at 06:28:50PM +0000, Chaitanya Kulkarni wrote: > On 02/20/2019 10:04 AM, Omar Sandoval wrote: > > On Tue, Feb 19, 2019 at 12:23:53PM -0800, Chaitanya Kulkarni wrote: > >> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@xxxxxxx> > >> --- > >> tests/nvme/002.out | 4996 ++++++++++++++++++++++++++-------------------------- > >> 1 file changed, 2498 insertions(+), 2498 deletions(-) > >> > >> diff --git a/tests/nvme/002.out b/tests/nvme/002.out > >> index aa71d8f..abecda5 100644 > >> --- a/tests/nvme/002.out > >> +++ b/tests/nvme/002.out > >> @@ -1,11 +1,11 @@ > >> Running nvme/002 > >> > >> -Discovery Log Number of Records 1000, Generation counter 1000 > >> +Discovery Log Number of Records 1000, Generation counter 2000 > >> =====Discovery Log Entry 0====== > >> trtype: loop > >> adrfam: pci > >> subtype: nvme subsystem > >> -treq: not specified > >> +treq: not specified, sq flow control disable supported > >> portid: X > >> trsvcid: > >> subnqn: blktests-subsystem-0 > > > > [snip] > > > > Why did this output change? An nvme-cli change, or a kernel change, or > > something else? And will this now fail with older versions of nvme-cli > > or the kernel instead? > > > > This change is specific to nvme-cli only. > > It should fail on older cli versions, we want latest cli/tools to be > used when running these testcases so that all the latest tools are > also been tested for the compliance, else we might be running tests > with any bugs with older version(s) which are fixed already. > > Actually I'd like to add quick nvme-cli version check at the start of > each test that will certainly help/force user to have a latest version. Perfect, I was going to suggest adding a check for the minimum version needed for each test.
