On Mon, Jan 21, 2019 at 09:47:32AM +0100, Christoph Hellwig wrote:
> On Thu, Jan 10, 2019 at 04:30:51PM +0200, Andy Shevchenko wrote:
> > There are new types and helpers that are supposed to be used in new code.
> >
> > As a preparation to get rid of legacy types and API functions do
> > the conversion here.
>
> This seems to miss a "lightnvm" in the subject line.
>
> > static inline void pblk_setup_uuid(struct pblk *pblk)
> > {
> > + guid_gen((guid_t *)&pblk->instance_uuid);
> > }
>
> I think we can just kill this wrapper.
>
> But more importantly the instance_uuid fied, and the header.uuid one
> it is copied from should be turned into an actual guid_t, the memcpys
> and memcmps should also be replaced with the proper UUID API.
header.uuid is defined using __u8 type, I'm not sure we can use guid_t there.
--
With Best Regards,
Andy Shevchenko
