On Thu, Dec 06, 2018 at 09:22:00PM +0100, Christoph Hellwig wrote: > On Thu, Dec 06, 2018 at 02:48:12PM -0200, Thadeu Lima de Souza Cascardo wrote: > > Without this exposure, lsblk will fail as it tries to find out the > > device's dev_t numbers. This causes a real problem for nvme multipath > > devices, as their slaves are hidden. > > > > Exposing them fixes the problem, even though trying to open the devices > > returns an error in the case of nvme multipath. So, right now, it's the > > driver's responsibility to return a failure to open hidden devices. > > So the problem with this is that it will cause udev to actually create > the /dev/nvmeXcYnZ nodes, which due to the previous patch will always > fail to open, which is a bit confusing. I guess we could live with this > if we add udev rules to supress the creation or something, but in general > it is a bit ugly. Well, udev could just look at the hidden attribute. At least to some, the fact that lsblk would fail was reason enough to revert the patches, so I would rather apply the entire set. We could add a message to the log when users try to open them, but given that some programs (udev is one) would open them without any user interaction, maybe we shouldn't. Cascardo.
