On 12/1/18 11:31 AM, Frank Lee wrote: > On Sun, Dec 2, 2018 at 2:11 AM Jens Axboe <axboe@xxxxxxxxx> wrote: >> >> On 12/1/18 7:24 AM, Yangtao Li wrote: >>> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. >>> >>> Signed-off-by: Yangtao Li <tiny.windzz@xxxxxxxxx> >>> --- >>> changes in v2: >>> -Modify some function names to avoid compilation errors >> >> The fact that your previous patch didn't even compile doesn't fill me >> with a lot of confidence in the amount of diligence and testing >> you apply to your patches. >> >> Why would you send something out that you didn't even compile? >> >> -- >> Jens Axboe >> > These changes are the same and only require a small change. > Most of the changes are fine, so it's a bit negligent. When someone is sending a patch for inclusion, at the very minimum I expect it to have been compiled, and preferably tested too. Doesn't matter how small the change is, even a one-liner should go through that. That said, I'm not a huge fan of changes like this. It completely hides what is going on for someone reading the code, and it's not like there's a win on code size for example. The only win seems to be that driver writes can't mess it up, which is a nice benefit. -- Jens Axboe
