On Sun, Dec 2, 2018 at 2:11 AM Jens Axboe <axboe@xxxxxxxxx> wrote: > > On 12/1/18 7:24 AM, Yangtao Li wrote: > > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > > > Signed-off-by: Yangtao Li <tiny.windzz@xxxxxxxxx> > > --- > > changes in v2: > > -Modify some function names to avoid compilation errors > > The fact that your previous patch didn't even compile doesn't fill me > with a lot of confidence in the amount of diligence and testing > you apply to your patches. > > Why would you send something out that you didn't even compile? > > -- > Jens Axboe > These changes are the same and only require a small change. Most of the changes are fine, so it's a bit negligent. MBR, Yangtao
