On 11/20/2018 4:00 AM, Sagi Grimberg wrote:
From: Sagi Grimberg <sagi@xxxxxxxxxxxxxxxxx> Signed-off-by: Sagi Grimberg <sagi@xxxxxxxxxxxxxxxxx> --- fabrics.c | 5 ++++- linux/nvme.h | 1 + 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/fabrics.c b/fabrics.c index be6a18cd4787..b4fac97253ba 100644 --- a/fabrics.c +++ b/fabrics.c @@ -96,6 +96,7 @@ static const char *arg_str(const char * const *strings, static const char * const trtypes[] = { [NVMF_TRTYPE_RDMA] = "rdma", [NVMF_TRTYPE_FC] = "fibre-channel", + [NVMF_TRTYPE_TCP] = "tcp", [NVMF_TRTYPE_LOOP] = "loop", }; @@ -703,11 +704,13 @@ retry: /* we can safely ignore the rest of the entries */ break; case NVMF_TRTYPE_RDMA: + case NVMF_TRTYPE_TCP: switch (e->adrfam) { case NVMF_ADDR_FAMILY_IP4: case NVMF_ADDR_FAMILY_IP6: /* FALLTHRU */ - len = sprintf(p, ",transport=rdma"); + len = sprintf(p, ",transport=%s", + e->trtype == NVMF_TRTYPE_RDMA ? "rdma" : "tcp");
So why not just use the trtypes array above? Regards, Arend