Re: [PATCH 6/7] block: make blk_poll() take a parameter on whether to spin or not

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Jens Axboe <axboe@xxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 6/7] block: make blk_poll() take a parameter on whether to spin or not
From: Sagi Grimberg <sagi@xxxxxxxxxxx>
Date: Tue, 20 Nov 2018 01:11:56 -0800
Cc: linux-block@xxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx
In-reply-to: <04b6015e-2949-750d-01a0-640373b406ea@kernel.dk>
References: <20181117214354.822-1-axboe@kernel.dk> <20181117214354.822-7-axboe@kernel.dk> <20181119080544.GF9622@infradead.org> <04b6015e-2949-750d-01a0-640373b406ea@kernel.dk>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1

This opportunistic poll is pretty bogus now as we never set the HIPRI
flag and it should probably be removed in a prep patch.  We should then
later try to use a scheme similar to your aio polling for the nvme
target as well.


I'll kill it in a pre-patch.


Agreed..

References:
- [PATCHSET v4] Various block optimizations
  - From: Jens Axboe
- [PATCH 6/7] block: make blk_poll() take a parameter on whether to spin or not
  - From: Jens Axboe
- Re: [PATCH 6/7] block: make blk_poll() take a parameter on whether to spin or not
  - From: Christoph Hellwig
- Re: [PATCH 6/7] block: make blk_poll() take a parameter on whether to spin or not
  - From: Jens Axboe

Prev by Date: Re: [PATCH 4.21 V3] blk-mq: not embed .mq_kobj and ctx->kobj into queue instance
Next by Date: Re: [PATCH nvme-cli v2 15/14] nvme: Add TCP transport
Previous by thread: Re: [PATCH 6/7] block: make blk_poll() take a parameter on whether to spin or not
Next by thread: [PATCH 7/7] blk-mq: ensure mq_ops ->poll() is entered at least once
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]