On Fri, Oct 05, 2018 at 07:13:32PM -0600, Jens Axboe wrote: > On 10/5/18 4:37 PM, Omar Sandoval wrote: > > On Fri, Oct 05, 2018 at 08:18:00AM -0600, Jens Axboe wrote: > >> On 10/4/18 11:35 AM, Bart Van Assche wrote: > >>> When debugging e.g. the SCSI timeout handler it is important that > >>> requests that have not yet been started or that already have > >>> completed are also reported through debugfs. > >> > >> Thanks, I like this better - applied. BTW, what's up with the > >> reverse ordering on this: > >> > >>> Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx> > >>> Cc: Christoph Hellwig <hch@xxxxxx> > >>> Cc: Ming Lei <ming.lei@xxxxxxxxxx> > >>> Cc: Hannes Reinecke <hare@xxxxxxxx> > >>> Cc: Johannes Thumshirn <jthumshirn@xxxxxxx> > >>> Cc: Martin K. Petersen <martin.petersen@xxxxxxxxxx> > >> > >> For some reason that really annoys me, and I see it in various > >> patches these days. IMHO the SOB should be last, with whatever > >> acks, reviews, CC, before that. > > > > I could've sworn that this guideline was even documented somewhere, but > > I can't find it now ¯\_(ツ)_/¯ > > My guess is that it's some newer git thing - but if it is, it's really > annoying and should be reverted. I end up fixing these up by hand. Isn't it the way patchwork adds the tags? And yes I also thought this is the correct way of adding the Ccs, etc.. -- Johannes Thumshirn Storage jthumshirn@xxxxxxx +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
