On 10/4/18 11:35 AM, Bart Van Assche wrote: > When debugging e.g. the SCSI timeout handler it is important that > requests that have not yet been started or that already have > completed are also reported through debugfs. Thanks, I like this better - applied. BTW, what's up with the reverse ordering on this: > Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx> > Cc: Christoph Hellwig <hch@xxxxxx> > Cc: Ming Lei <ming.lei@xxxxxxxxxx> > Cc: Hannes Reinecke <hare@xxxxxxxx> > Cc: Johannes Thumshirn <jthumshirn@xxxxxxx> > Cc: Martin K. Petersen <martin.petersen@xxxxxxxxxx> For some reason that really annoys me, and I see it in various patches these days. IMHO the SOB should be last, with whatever acks, reviews, CC, before that. -- Jens Axboe