On Thu, Mar 15, 2018 at 08:08:14AM -0700, Bart Van Assche wrote: > This patch avoids that sparse complains about using integer types > incorrectly (u32, __le32, __be32, ...) by splitting struct cache_sb > into two different structures: > - struct cache_sb in which all integer members except csum have > CPU endianness. > - struct cache_sb_le in which all integer members except csum are > declared as little endian. Can you call this cache_sb_disk to name it after the purpose instead of the implementation? Except for that this looks like the right fix: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
