Omar Sandoval <osandov@xxxxxxxxxxx> writes:
> On Tue, Dec 19, 2017 at 11:47:09AM +0100, Johannes Thumshirn wrote:
>> xiao yang <yangx.jy@xxxxxxxxxxxxxx> writes:
>>
>> > +requires() {
>> > + _have_program mkfs.ext3
>> > +}
>> [...]
>> > + # Format
>> > + mkfs.ext3 -F "$TEST_DEV" >> "$FULL" 2>&1
>>
>> What's the reason to limit the test case to ext3 only? Can you switch it
>> to the generic 'mkfs' command? IIRC we require 'util-linux' to be
>> present for blktests but mkfs.ext3 is (at least in SUSE based distros)
>> in the e2fsprogs package.
>
> I'm fine with only testing one specific filesystem, since we're really
> testing generic functionality and not any filesystem code. And according
> to the manpage, bare mkfs is deprecated. I'm fine with requiring
> e2fsprogs for this test, and xiao yang added the _have_program there for
> it.
what about something like (totally untested):
if _have_program mkfs.ext3; then
mkfs_prog="mkfs.ext3"
return 1
elif _have_program mkfs.xfs; then
mkfs_prog="mkfs.xfs"
return 1
elif _have_program mkfs.brtfs; then
mkfs_prog="mkfs.brtfs"
return 1
else
retrun 0
fi
--
Johannes Thumshirn Storage
jthumshirn@xxxxxxx +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
