On Tue, Dec 19, 2017 at 11:47:09AM +0100, Johannes Thumshirn wrote:
> xiao yang <yangx.jy@xxxxxxxxxxxxxx> writes:
>
> > +requires() {
> > + _have_program mkfs.ext3
> > +}
> [...]
> > + # Format
> > + mkfs.ext3 -F "$TEST_DEV" >> "$FULL" 2>&1
>
> What's the reason to limit the test case to ext3 only? Can you switch it
> to the generic 'mkfs' command? IIRC we require 'util-linux' to be
> present for blktests but mkfs.ext3 is (at least in SUSE based distros)
> in the e2fsprogs package.
I'm fine with only testing one specific filesystem, since we're really
testing generic functionality and not any filesystem code. And according
to the manpage, bare mkfs is deprecated. I'm fine with requiring
e2fsprogs for this test, and xiao yang added the _have_program there for
it.
> apart from that:
> Reviewed-by: Johannes Thumshirn <jthumshirn@xxxxxxx>
