On 11/24/2017 01:32 AM, Christoph Hellwig wrote: > On Thu, Nov 23, 2017 at 10:04:55PM -0700, Jens Axboe wrote: >>> + NVME_FC_Q_LIVE = (1 << 1), >>> }; >>> >>> for flags that are used with set_bit() and friends? That's just >>> misleading, should be 0, 1, etc, not a shift. >>> >>> The rest looks pretty straight forward, but the above is an eye sore. > > Yes, it is misleading, but so far harmless. Yeah, but it just takes a few more bits... > Your fixup looks good to me: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> Thanks, I've added it. -- Jens Axboe
