On Fri, Nov 17, 2017 at 11:29 AM, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote: > > "F*ck no, that code is too ugly, you need to write it so that it can > be maintained". Dammit, the rest of the pull looks ok, so I'll take it anyway. But I really do expect you to (a) clean up that mess - maybe with my patch as an example, but maybe some entirely different way. The patch I sent is already deleted from my tree, it was purely meant as an example. (b) really push back on people when they send you ugly code It shouldn't have to always be me being upset and pushing back on the block pulls. Linus