On Mon, Sep 25, 2017 at 04:17:27PM +0000, Bart Van Assche wrote: > On Mon, 2017-09-25 at 10:36 +0800, Ming Lei wrote: > > On Sat, Sep 23, 2017 at 6:13 AM, Bart Van Assche <bart.vanassche@xxxxxxx> wrote: > > > It is known that during the resume following a hibernate sometimes the > > > system hangs instead of coming up properly. This patch series fixes this > > > problem. This patch series is an alternative for Ming Lei's "[PATCH V5 > > > 0/10] block/scsi: safe SCSI quiescing" patch series. The advantages of > > > this patch series are: > > > > No, your patch doesn't fix scsi quiesce on block legacy, so not an alternative > > of my patchset at all. > > This patch series definitely is an alternative for blk-mq/scsi-mq. And as you > know my approach can be extended easily to the legacy SCSI core by adding > blk_queue_enter() / blk_queue_exit() calls where necessary in the legacy block > layer. I have not done this because the bug report was against scsi-mq and not > against the legacy SCSI core. Additionally, since the legacy block layer and > SCSI core are on their way out I did not want to spend time on modifying these. Let me show you the legacy report and verification: https://www.spinics.net/lists/linux-block/msg17237.html If you have transport_spi device at hand, the issue can be reproduced in several minutes by the following way: - set nr_request of this disk as 4 - while true; do trigger revalidate once in 5 seconds meantime run heavy/background concurrent I/O -- Ming
