On Sat, Sep 23, 2017 at 6:13 AM, Bart Van Assche <bart.vanassche@xxxxxxx> wrote:
> Hello Jens,
>
> It is known that during the resume following a hibernate sometimes the
> system hangs instead of coming up properly. This patch series fixes this
> problem. This patch series is an alternative for Ming Lei's "[PATCH V5
> 0/10] block/scsi: safe SCSI quiescing" patch series. The advantages of
> this patch series are:
No, your patch doesn't fix scsi quiesce on block legacy, so not an alternative
of my patchset at all.
> - Easier to review because no new race conditions are introduced between
> queue freezing and blk_cleanup_queue(). As the discussion that followed
> Ming's patch series shows the correctness of the new code is hard to
> verify.
I don't agree that my code is hard to verify. I have replied all your comments,
and the only thing you pay special attention to is that the race between preempt
quiesce and blk_cleanup_queue():
- that is simply not a race
- we have depended on drivers(legacy or blk-mq) to handle request correctly
after queue is set as dying for long long time
--
Ming Lei
