Re: [PATCH] block: sed-opal: Set MBRDone on S3 resume path if TPER is MBREnabled

[Jens Axboe <axboe@xxxxxxxxx>]

On Thu, Aug 31 2017, Scott Bauer wrote:
> @@ -2345,6 +2371,11 @@ bool opal_unlock_from_suspend(struct opal_dev *dev)
>  				 suspend->unlk.session.sum);
>  			was_failure = true;
>  		}
> +		if (dev->mbr_enabled) {
> +			ret = __opal_set_mbr_done(dev, &suspend->unlk.session.opal_key);
> +			if (ret)
> +				pr_debug("Failed to set MBR Done in S3 resume\n");
> +		}

Should ret != 0 set was_failure = true here?

-- 
Jens Axboe