On Thu, Aug 31, 2017 at 02:10:36PM -0600, Jon Derrick wrote: > Hey Scott, > > +static int __opal_set_mbr_done(struct opal_dev *dev, struct opal_key *key) > > +{ > > + u8 mbr_done_tf = 1; > > + const struct opal_step mbrdone_step [] = { > > + { opal_discovery0, }, > > + { start_admin1LSP_opal_session, key }, > > + { set_mbr_done, &mbr_done_tf }, > Do you need to end_opal_session here? > Yep, sure do. I'll wait for Christoph to look at it tonight before spinning another. > > + { NULL, } > > + }; > > +