On 08/28/2017 03:04 PM, Shaohua Li wrote: > On Mon, Aug 28, 2017 at 02:55:59PM -0600, Jens Axboe wrote: >> On 08/28/2017 02:49 PM, Shaohua Li wrote: >>> Commit 2984c86(nullb: factor disk parameters) has a typo. The >>> nullb_device allocation/free is done outside of null_add_dev. The commit >>> accidentally frees the nullb_device in error code path. >> >> Is the code in nullb_device_power_store() correct after this? > > Yes, for runtime disk configuration, we allocate the device in > nullb_group_make_item and free the device in nullb_device_release. the > nullb_device_power_store only does null_add_dev/null_del_dev, not allocate/free > dev. OK good, just wanted to confirm. >> Also, looks like the second else if in there should be using >> 'dev' instead of to_nullb_device(item)->power. > > Ah, yes, it should be 'dev->power'. dev == to_nullb_device(item). Do you want > me to send a separate patch to do the cleanup? No worries, I'll just do it myself. -- Jens Axboe
