On 08/28/2017 02:49 PM, Shaohua Li wrote: > Commit 2984c86(nullb: factor disk parameters) has a typo. The > nullb_device allocation/free is done outside of null_add_dev. The commit > accidentally frees the nullb_device in error code path. Is the code in nullb_device_power_store() correct after this? Also, looks like the second else if in there should be using 'dev' instead of to_nullb_device(item)->power. -- Jens Axboe
