On Mon, Jun 05, 2017 at 03:15:31PM -0600, Scott Bauer wrote: > I'm not familiar at all with ATA, but I noticed there was no unlock from suspend support > in the series. Does ATA not have a way to determine if we're coming out of a suspend? I don't know, and not having a test system with a OPAL capable driver and suspend support I could not even test the code. > I see there are some power-ops in scsi/sd.c, if you do want to add it you can mabe toss a > > if (sdkp->security) > opal_unlock_from_suspend(sdpk->opal_dev) > > somewhere in the resume path? We handle null opal_devs and no unlock from suspend list > so calling it when nothing is set up is just a no-op. Yeah, maybe. We'll just need someone who could test it first.