On Sat, Mar 15, 2025 at 09:34:42AM +0000, Benno Lossin wrote: [...] > > The rest Rust code changes look good to me. Although I would suggest you > > to split this patch into several patches: you can do the conversion from > > "as" pattern to provenance API one file by one file, and this make it > > easier for people to review. And after the conversions are done, you can > > introduce the Makefile changes. > > I think it's fine to do several of the `as` conversions in a single Well, "fine" != "recommended", right? ;-) If the patch was split, reviewers would be able to give Reviewed-by to individual patches that looks fine trivially. Then it's easier to make progress every iteration, and also allows partially applying the changes. Of course it doesn't have to be file-by-file. Regards, Boqun > patch, but splitting off the makefile changes is a good idea. > > --- > Cheers, > Benno >
