On Thu, 06 Mar 2025 15:09:53 +0530, Nilay Shroff wrote:
> Currently, hctx attributes (nr_tags, nr_reserved_tags, and cpu_list)
> are protected using `q->sysfs_lock`. However, these attributes can be
> updated in multiple scenarios:
> - During the driver's probe method.
> - When updating nr_hw_queues.
> - When writing to the sysfs attribute nr_requests,
> which can modify nr_tags.
> The nr_requests attribute is already protected using q->elevator_lock,
> but none of the update paths actually use q->sysfs_lock to protect hctx
> attributes. So to ensure proper synchronization, replace q->sysfs_lock
> with q->elevator_lock when reading hctx attributes through sysfs.
>
> [...]
Applied, thanks!
[1/1] block: protect hctx attributes/params using q->elevator_lock
commit: 5abba4cebec0a591ca7e7f55701e42cd5dc059af
Best regards,
--
Jens Axboe
