Re: [PATCHv6 0/7] block: fix lock order and remove redundant locking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 04 Mar 2025 15:52:29 +0530, Nilay Shroff wrote:
> After we modeled the freeze & enter queue as lock for supporting lockdep
> under commit f1be1788a32e ("block: model freeze & enter queue as lock
> for supporting lockdep"), we received numerous lockdep splats. And one
> of those splats[1] reported the potential deadlock due to incorrect lock
> ordering issue between q->sysfs-lock and q->q_usage_counter. So some of
> the patches in this series are aimed to cut the dependency between q->
> sysfs-lock and q->q_usage_counter.
> 
> [...]

Applied, thanks!

[1/7] block: acquire q->limits_lock while reading sysfs attributes
      commit: 6e51a1279cd60cb93e3379ff140d8fa6c39ecf20
[2/7] block: move q->sysfs_lock and queue-freeze under show/store method
      commit: b07a889e833555735ce72ca4a6d39f4c2ca725ba
[3/7] block: remove q->sysfs_lock for attributes which don't need it
      commit: d23977fee1ee838316fb1b00945064a146460843
[4/7] block: introduce a dedicated lock for protecting queue elevator updates
      commit: 1bf70d08cc3b55abd1763e6dff5855cb8dd8318b
[5/7] block: protect nr_requests update using q->elevator_lock
      commit: 3efe7571c3ae2b6481253a2616c2bb3fbadd503b
[6/7] block: protect wbt_lat_usec using q->elevator_lock
      commit: 245618f8e45ff4f79327627b474b563da71c2c75
[7/7] block: protect read_ahead_kb using q->limits_lock
      commit: 5e40f4452dc9a3fb44d13bb6bc7032f3911a2675

Best regards,
-- 
Jens Axboe







[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux