Re: [PATCH v2 03/12] blk-mq-debugfs: error on long write to queue "state" file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2017-05-04 at 00:31 -0700, Omar Sandoval wrote:
> From: Omar Sandoval <osandov@xxxxxx>
> 
> blk_queue_flags_store() currently truncates and returns a short write if
> the operation being written is too long. This can give us weird results,
> like here:
> 
> $ echo "run            bar"
> echo: write error: invalid argument
> $ dmesg
> [ 1103.075435] blk_queue_flags_store: unsupported operation bar. Use either 'run' or 'start'
> 
> Instead, return an error if the user does this. While we're here, make
> the argument names consistent with everywhere else in this file.

Reviewed-by: Bart Van Assche <bart.vanassche@xxxxxxxxxxx>



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux