On 05/04/2017 09:31 AM, Omar Sandoval wrote: > From: Omar Sandoval <osandov@xxxxxx> > > blk_queue_flags_store() currently truncates and returns a short write if > the operation being written is too long. This can give us weird results, > like here: > > $ echo "run bar" > echo: write error: invalid argument > $ dmesg > [ 1103.075435] blk_queue_flags_store: unsupported operation bar. Use either 'run' or 'start' > > Instead, return an error if the user does this. While we're here, make > the argument names consistent with everywhere else in this file. > > Signed-off-by: Omar Sandoval <osandov@xxxxxx> > --- > block/blk-mq-debugfs.c | 19 ++++++++++++------- > 1 file changed, 12 insertions(+), 7 deletions(-) > Reviewed-by: Hannes Reinecke <hare@xxxxxxxx> Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)
