On Mon, Mar 03, 2025 at 12:06:44PM +0000, Shinichiro Kawasaki wrote: > Hi, Ming, thank you for the patch. > > On Feb 24, 2025 / 17:59, Ming Lei wrote: > > Add test for covering prioritized meta IO when throttling, regression > > test for commit 29390bb5661d ("blk-throttle: support prioritized processing > > of metadata"). > > I ran this test case with the kernel v6.14-rc3, and it passed. Then I reverted > the commit 29390bb5661d form the kernel, and still the test case passed. I > wonder how can I make the test case fail. The commit was in v6.12-rc1 tag, so > do I need to try with v6.11 kernel to see it fails? > > I have two nit comments in line. If you respin the patch, please consider to > fold them in. The test needs to setup cgroup v1, I guess. Kuai, any idea for setting one test to cover the change of commit 29390bb5661d ("blk-throttle: support prioritized processing of metadata")? Thanks, Ming