Hi, Ming, thank you for the patch.
On Feb 24, 2025 / 17:59, Ming Lei wrote:
> Add test for covering prioritized meta IO when throttling, regression
> test for commit 29390bb5661d ("blk-throttle: support prioritized processing
> of metadata").
I ran this test case with the kernel v6.14-rc3, and it passed. Then I reverted
the commit 29390bb5661d form the kernel, and still the test case passed. I
wonder how can I make the test case fail. The commit was in v6.12-rc1 tag, so
do I need to try with v6.11 kernel to see it fails?
I have two nit comments in line. If you respin the patch, please consider to
fold them in.
>
> Cc: Yu Kuai <yukuai1@xxxxxxxxxxxxxxx>
> Signed-off-by: Ming Lei <ming.lei@xxxxxxxxxx>
> ---
> tests/throtl/006 | 58 ++++++++++++++++++++++++++++++++++++++++++++
> tests/throtl/006.out | 4 +++
> tests/throtl/rc | 19 +++++++++++++++
> 3 files changed, 81 insertions(+)
> create mode 100755 tests/throtl/006
> create mode 100644 tests/throtl/006.out
>
> diff --git a/tests/throtl/006 b/tests/throtl/006
> new file mode 100755
> index 0000000..4baadaf
> --- /dev/null
> +++ b/tests/throtl/006
[...]
> +test() {
> + echo "Running ${TEST_NAME}"
> +
> + if ! _set_up_throtl memory_backed=1; then
> + return 1;
> + fi
> +
> + mkdir -p "${TMPDIR}/mnt"
Nit: the long option --parents is preferred to the short option -p.
> + mkfs.ext4 -E lazy_itable_init=0,lazy_journal_init=0 -F "/dev/${THROTL_DEV}" >> "$FULL" 2>&1
Nit: this line is a big long, then I suggest to split into two lines with
backslash.
