On Fri, Feb 07, 2025 at 11:24:10AM +0000, Shinichiro Kawasaki wrote: > On Feb 04, 2025 / 14:57, Luis Chamberlain wrote: > > This v2 series addresses the feedback from the first series [0], namely: > > > > - uses less device specific names > > - checks for fio arguments --filename or --directory to extract the > > min io target or path > > - adds a new patch to verify the sector size will work before creating > > a filesystem > > - a diagram is provided to help easily disect why we use statx > > blocksize, although not included in the docs we could later if > > it helps > > Thanks for this v2 series. I ran the tests, and they look working. Good. > I also ran "make check" and saw shellcheck warnings. Could you address them? > > $ make check > shellcheck -x -e SC2119 -f gcc check common/* \ I fixed them, will submit shortly. > > This goes tested against a 64k sector size NVMe drive, the patches for > > which will be posted soon rebased on v6.14-rc1. > > > > [0] https://lkml.kernel.org/r/20241218112153.3917518-1-mcgrof@xxxxxxxxxx > > [1] https://docs.google.com/drawings/d/e/2PACX-1vQeZaBq2a0dgg9RDyd_XAJBSH-wbuGCtm95sLp2oFj66oghHWmXunib7tYOTPr84AlQ791VGiaKWvKF/pub?w=1006&h=929 > > I'm interested in the link [1]. I guess it is the diagram noted, isn't it? > But it looks like I can not access it. I just see a blank page. That's so odd, I embedded this document here too: https://kernelnewbies.org/KernelProjects/large-block-size It is below the "stat --print=%o" example: Can you see that image? Luis
