On Feb 04, 2025 / 14:57, Luis Chamberlain wrote:
> This v2 series addresses the feedback from the first series [0], namely:
>
> - uses less device specific names
> - checks for fio arguments --filename or --directory to extract the
> min io target or path
> - adds a new patch to verify the sector size will work before creating
> a filesystem
> - a diagram is provided to help easily disect why we use statx
> blocksize, although not included in the docs we could later if
> it helps
Thanks for this v2 series. I ran the tests, and they look working. Good.
I also ran "make check" and saw shellcheck warnings. Could you address them?
$ make check
shellcheck -x -e SC2119 -f gcc check common/* \
tests/*/rc tests/*/[0-9]*[0-9] src/*.sh
common/fio:212:8: warning: Declare and assign separately to avoid masking return values. [SC2155]
common/fio:213:16: note: Double quote to prevent globbing and word splitting. [SC2086]
common/fio:218:8: warning: Declare and assign separately to avoid masking return values. [SC2155]
common/fio:219:74: note: Double quote to prevent globbing and word splitting. [SC2086]
common/xfs:16:8: warning: Declare and assign separately to avoid masking return values. [SC2155]
common/xfs:16:21: note: Double quote to prevent globbing and word splitting. [SC2086]
common/xfs:19:8: warning: Declare and assign separately to avoid masking return values. [SC2155]
common/xfs:19:33: note: Double quote to prevent globbing and word splitting. [SC2086]
common/xfs:32:53: note: Double quote to prevent globbing and word splitting. [SC2086]
tests/block/003:21:8: warning: Declare and assign separately to avoid masking return values. [SC2155]
tests/block/003:21:30: note: Double quote to prevent globbing and word splitting. [SC2086]
tests/block/003:26:22: note: Double quote to prevent globbing and word splitting. [SC2086]
tests/block/007:34:8: warning: Declare and assign separately to avoid masking return values. [SC2155]
tests/block/007:34:30: note: Double quote to prevent globbing and word splitting. [SC2086]
tests/block/007:41:17: note: Double quote to prevent globbing and word splitting. [SC2086]
tests/nvme/049:22:8: warning: Declare and assign separately to avoid masking return values. [SC2155]
tests/nvme/049:22:30: note: Double quote to prevent globbing and word splitting. [SC2086]
tests/nvme/049:27:8: warning: Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. [SC2206]
tests/nvme/049:42:42: note: Double quote to prevent globbing and word splitting. [SC2086]
tests/nvme/049:42:62: note: Double quote to prevent globbing and word splitting. [SC2086]
make: *** [Makefile:21: check] Error 1
I will comment on the 1st and 4th patches. Other than the shellcheck
warnings, the 2nd and 3rd patches look good to me.
>
> This goes tested against a 64k sector size NVMe drive, the patches for
> which will be posted soon rebased on v6.14-rc1.
>
> [0] https://lkml.kernel.org/r/20241218112153.3917518-1-mcgrof@xxxxxxxxxx
> [1] https://docs.google.com/drawings/d/e/2PACX-1vQeZaBq2a0dgg9RDyd_XAJBSH-wbuGCtm95sLp2oFj66oghHWmXunib7tYOTPr84AlQ791VGiaKWvKF/pub?w=1006&h=929
I'm interested in the link [1]. I guess it is the diagram noted, isn't it?
But it looks like I can not access it. I just see a blank page.
