On Mon, Jan 13, 2025 at 05:50:34AM -0800, Christoph Hellwig wrote: > NAK for the same reason as v1. It's not needed because there is no > deadlock, just a false positive due to missing annotations of lock Yes, but annotation should be the last straw. > instances, and we need to fsync with a frozen queue to ensure there > is no outstanding I/O. loop_configure() is on unbound loop, so there isn't outstanding I/O. loop_change_fd() is switching to this new file, so no outstanding I/O on this new file before unfreeze. The other two can only switch to buffered IO, which needn't the fsync. So can you point out anything is wrong? And this way is sort of simplification. Thanks, Ming
