Re: [PATCH v2] block: Use enum for blk-mq tagset flags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/01/2025 08:27, Christoph Hellwig wrote:
On Fri, Jan 03, 2025 at 08:23:02AM +0000, John Garry wrote:
- better to not have unused gaps
Who cares?

it's not that important, as long as it the flags are properly ordered and it's obvious where the gaps are

> >> - catch missing blk-mq debugfs array names
	- this has been a problem in the past
Again who really cares?

People who use blk-mq debugfs

And maybe the maintainer when we have the tedious routine of a new flag being added but the debugfs entry being missed and then the follow on patch (to add the entry).


Cons:
- boilerplate

Anyway, I feel too strongly about all of this.






[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux