On Fri, Jan 03, 2025 at 08:23:02AM +0000, John Garry wrote: > - better to not have unused gaps Who cares? > - catch missing blk-mq debugfs array names > - this has been a problem in the past Again who really cares? > > Cons: > - boilerplate > > A compromise could be to use some macro to evaluate the flags, like: > #define BLK_MQ_F(flag) (1 << BLK_MQ_B_##flag) Hell no. The debugfs mess is already annoying as f**k because of all that macro magic that makes it impossible to grep for. Don't add more of that crap that just makes life hell.