Re: [PATCH v2 2/3] blk-mq: Move more error handling into blk_mq_submit_bio()

[Bart Van Assche <bvanassche@xxxxxxx>]

On 12/17/24 3:37 PM, Damien Le Moal wrote:
> On 2024/12/17 14:38, Bart Van Assche wrote:
> > diff --git a/block/blk-mq.c b/block/blk-mq.c
> > index 8d2aab4d9ba9..f4300e608ed8 100644
> > --- a/block/blk-mq.c
> > +++ b/block/blk-mq.c
> > @@ -2968,12 +2968,9 @@ static struct request *blk_mq_get_new_requests(struct request_queue *q,
> >   	}
> >   
> >   	rq = __blk_mq_alloc_requests(&data);
> > -	if (rq)
> > -		return rq;
> > -	rq_qos_cleanup(q, bio);
> > -	if (bio->bi_opf & REQ_NOWAIT)
> > -		bio_wouldblock_error(bio);
> > -	return NULL;
> > +	if (!rq)
>
> No unlikely() here ?

I will add unlikely here().

Thanks,

Bart.